Replace duplexify and friends with readable-stream v4
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
approved these changes
Jul 2, 2022
Member
Author
That test failure is unrelated to |
Member
Author
|
I managed to work around that, but then another issue popped up. Don't want to spend more time on that, so I'm just gonna drop support of Node.js 12 in In any case, this PR is good to go. |
This was referenced Jul 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #6 and #1. I've forked
length-prefixed-streamto make that usereadable-streamv4 as well.Semver-major because the streams exposed here now don't emit duplexify's custom events (prefinish, preend, cork, uncork) although it's unlikely that anyone is using those events (or even
many-levelitself, which is relatively new).One thing left to do: test against
rave-level(which also depends onreadable-streamand failed a test: Level/rave-level#3).cc @ronag